Skip to content

Add skip field to disable conversations with a reason#6

Merged
emac-E merged 1 commit into
emac-E:mainfrom
Lifto:feat/skip-conversations
Apr 9, 2026
Merged

Add skip field to disable conversations with a reason#6
emac-E merged 1 commit into
emac-E:mainfrom
Lifto:feat/skip-conversations

Conversation

@Lifto

@Lifto Lifto commented Apr 9, 2026

Copy link
Copy Markdown

Summary

  • Adds skip (bool) and skip_reason (string) fields to conversation YAML
  • Conversations with skip: true are excluded during evaluation
  • skip_reason is documentation-only — not logged at runtime

Usage

- conversation_group_id: gnome_configuration
  skip: true
  skip_reason: "Vague expected response — test needs rewrite"
  turns:
    - turn_id: turn1
      query: "How do I configure GNOME in RHEL 10?"
      expected_response: "..."

Changes

  • core/models/data.py: Add skip and skip_reason fields to EvaluationData
  • core/system/validator.py: Filter skipped conversations after scope filtering
  • tests/unit/core/system/test_validator.py: Two tests — skip=True excluded, skip=False kept

Adds skip and skip_reason fields to EvaluationData. Conversations
with skip: true are silently excluded during loading. skip_reason
is documentation-only — it stays in the YAML for humans to read.

@emac-E emac-E left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea! Thanks for adding it!

@emac-E emac-E merged commit ef06c1a into emac-E:main Apr 9, 2026
5 of 15 checks passed
emac-E pushed a commit that referenced this pull request Apr 10, 2026
Add some type hints into rag_eval.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants